Bug 102876

Summary: [V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-11-20 22:03:19 PST
It doesn't make sense to have one custom cpp file for XXX::constructorCallback() only. We can move XXX::constructorCallback() in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp and thus remove v8/custom/V8XXXConstructor.cpp. Note: Some XXX::constructorCallback()s are already written in v8/custom/V8XXXCustom.cpp. JSC already has almost all XXX::constructorCallback()s in js/JSXXXCustom.cpp.
Attachments
Patch (6.71 KB, patch)
2012-11-20 22:06 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-20 22:06:02 PST
Created attachment 175338 [details] Patch
Kentaro Hara
Comment 2 2012-11-20 22:17:11 PST
Comment on attachment 175338 [details] Patch Thanks!
WebKit Review Bot
Comment 3 2012-11-20 22:50:59 PST
Comment on attachment 175338 [details] Patch Clearing flags on attachment: 175338 Committed r135354: <http://trac.webkit.org/changeset/135354>
WebKit Review Bot
Comment 4 2012-11-20 22:51:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.