Bug 102850

Summary: Web Inspector: IndexedDB: remove setVersion from inspector tests
Product: WebKit Reporter: David Grogan <dgrogan>
Component: Web Inspector (Deprecated)Assignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, jsbell, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94972    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

David Grogan
Reported 2012-11-20 16:47:13 PST
IndexedDB: remove setVersion from inspector tests
Attachments
Patch (9.37 KB, patch)
2012-11-20 16:48 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (9.07 KB, patch)
2012-11-20 16:52 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2012-11-20 16:53 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.80 KB, patch)
2012-11-21 00:27 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-11-20 16:48:08 PST
Created attachment 175300 [details] Patch
David Grogan
Comment 2 2012-11-20 16:52:52 PST
Created attachment 175304 [details] Patch
David Grogan
Comment 3 2012-11-20 16:53:47 PST
Created attachment 175305 [details] Patch
David Grogan
Comment 4 2012-11-20 16:54:20 PST
Josh, could you look at this?
David Grogan
Comment 5 2012-11-20 17:45:36 PST
Vsevik, could you review this?
Vsevolod Vlasov
Comment 6 2012-11-20 22:02:12 PST
Comment on attachment 175305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175305&action=review > LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt:23 > + version: If I understand correctly, the version field should go now? Would you care to remove it from test (and expectations)? Just remove line 22 in database-structure.html: InspectorTest.addResult(" version: " + database.version); > LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:145 > + request.onupgradeneeded = function(e) { We prefer named function style in inspector (and "{" should go to the next line): request.onupgradeneeded = onUpgradeNeeded; function onUpgradeNeeded(e) { ... }
David Grogan
Comment 7 2012-11-21 00:26:01 PST
Comment on attachment 175305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175305&action=review Thanks for the review. Updated patch coming up. >> LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt:23 >> + version: > > If I understand correctly, the version field should go now? Would you care to remove it from test (and expectations)? > Just remove line 22 in database-structure.html: InspectorTest.addResult(" version: " + database.version); Done. >> LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:145 >> + request.onupgradeneeded = function(e) { > > We prefer named function style in inspector (and "{" should go to the next line): > > request.onupgradeneeded = onUpgradeNeeded; > > function onUpgradeNeeded(e) > { > ... > } Done.
David Grogan
Comment 8 2012-11-21 00:27:51 PST
Created attachment 175357 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-11-21 02:12:59 PST
Comment on attachment 175357 [details] Patch for landing Clearing flags on attachment: 175357 Committed r135365: <http://trac.webkit.org/changeset/135365>
WebKit Review Bot
Comment 10 2012-11-21 02:13:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.