Bug 102840

Summary: Remove unused ScrollByPixelVelocity
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: PlatformAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, allan.jensen, benjamin, jamesr, ojan, rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robert Kroeger
Reported 2012-11-20 14:54:12 PST
Per https://bugs.webkit.org/show_bug.cgi?id=80311 I added support for fling via ScrollAnimatorNone using the ScrollByPixelVelocity scroll subtype. This code was ill-considered and (as best as I can tell) not used by any platform as it doesn't actually work properly. Remove it.
Attachments
Patch (12.61 KB, patch)
2012-11-21 11:41 PST, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (14.00 KB, patch)
2012-11-21 12:30 PST, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-11-21 11:41:36 PST
Created attachment 175491 [details] Patch
Robert Kroeger
Comment 2 2012-11-21 12:30:05 PST
Created attachment 175499 [details] Patch
Robert Kroeger
Comment 3 2012-11-21 12:35:57 PST
Allan: I believe that ScrollByPixelVelocityWheelEvent-type wheel events with non-zero velocities are never actually dispatched on any platform. I.E.: GestureScrollEnd never initiates a fling. It doesn't on Chromium or Mac platforms. Could you have a look at this patch and comment?
Allan Sandfeld Jensen
Comment 4 2012-11-23 07:23:36 PST
(In reply to comment #3) > Allan: I believe that ScrollByPixelVelocityWheelEvent-type wheel events with non-zero velocities are never actually dispatched on any platform. I.E.: GestureScrollEnd never initiates a fling. It doesn't on Chromium or Mac platforms. Could you have a look at this patch and comment? Qt never uses GestureScrollEnd with velocity either. This is either provided by hardware (mouse wheel, touchpad) or the application environment (touch screen).
WebKit Review Bot
Comment 5 2012-11-23 16:43:24 PST
Comment on attachment 175499 [details] Patch Clearing flags on attachment: 175499 Committed r135638: <http://trac.webkit.org/changeset/135638>
WebKit Review Bot
Comment 6 2012-11-23 16:43:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.