Bug 102818

Summary: Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, eric.carlson, feature-media-reviews, japhet, keishi, loislo, ojan, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Ilya Tikhonovsky
Reported 2012-11-20 09:09:46 PST
Our test bot counts pointers which don't match with objects allocated by tcmalloc. This counter becomes nonzero after instrumenting ActiveDOMObject class. It happens because it is the base class for many other classes. ~30 And almost all these classes use multiple inheritance.
Attachments
Patch (7.67 KB, patch)
2012-11-20 09:13 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (10.80 KB, patch)
2012-11-21 01:45 PST, Ilya Tikhonovsky 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-11-20 09:13:10 PST
Created attachment 175230 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-11-21 01:45:10 PST
Created attachment 175378 [details] Patch
Ilya Tikhonovsky
Comment 3 2012-11-21 04:27:44 PST
Committed r135384: <http://trac.webkit.org/changeset/135384>
Note You need to log in before you can comment on or make changes to this bug.