Bug 102812

Summary:

Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.

Product:

WebKit

Reporter:

Mike West <mkwst>

Component:

WebCore Misc.

Assignee:

Mike West <mkwst>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, jochen, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Mike West

Reported 2012-11-20 06:53:21 PST

"ScriptCallStackFactory.h" is included in a few files where it doesn't seem to be required. Since I'm in the process of centralizing stack trace generation anyway, I'll just clean this up as a drive-by.

Attachments
Patch (3.77 KB, patch) 2012-11-20 06:57 PST, Mike West	no flags	Details Formatted Diff Diff
Patch for landing (3.86 KB, patch) 2012-11-20 09:42 PST, Mike West	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike West

Comment 1 2012-11-20 06:57:33 PST

Created attachment 175208 [details] Patch

Mike West

Comment 2 2012-11-20 06:58:53 PST

Hey Jochen, assuming this compiles, WDYT?

jochen

Comment 3 2012-11-20 07:01:19 PST

Comment on attachment 175208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175208&action=review > Source/WebCore/ChangeLog:3 > + Remove '#include "ScriptCallStackFactory.h"' include when unnecessary. you also remove one occurrence of ScriptCallStack.h, can you somehow note this in the ChangeLog

Mike West

Comment 4 2012-11-20 09:42:11 PST

Created attachment 175234 [details] Patch for landing

WebKit Review Bot

Comment 5 2012-11-20 09:59:27 PST

Comment on attachment 175234 [details] Patch for landing Clearing flags on attachment: 175234 Committed r135291: <http://trac.webkit.org/changeset/135291>

WebKit Review Bot

Comment 6 2012-11-20 09:59:31 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.