Bug 102805

Summary: [V8] Change a return type of V8Parameter::prepare() from bool to void
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, tyoshino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102981    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Fixed test failures none

Description Kentaro Hara 2012-11-20 05:27:51 PST 
This is an incremental step for V8Parameter refactoring.

V8Parameter::prepare() is always called just after V8Parameter's constructor. So I want to move the logic of V8Parameter::prepare() to V8Parameter's constructor. In preparation for that, this patch changes the return type of V8Parameter::prepare() from bool to void (because a constructor cannot return any value).
Comment 1 Kentaro Hara 2012-11-20 05:35:09 PST 
Created attachment 175196 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-20 10:32:01 PST 
Comment on attachment 175196 [details]
Patch

Attachment 175196 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14911682

New failing tests:
fast/workers/worker-constructor.html
storage/websql/sql-error-codes.html
inspector/console/alert-toString-exception.html
http/tests/websocket/tests/hybi/send-throw.html
fast/workers/storage/execute-sql-args-sync.html
fast/workers/storage/open-database-inputs-sync.html
fast/workers/storage/execute-sql-args-worker.html
fast/workers/storage/sql-exception-codes-sync.html
storage/websql/execute-sql-args.html
Comment 3 Adam Barth 2012-11-20 10:52:29 PST 
Comment on attachment 175196 [details]
Patch

Looks like you have some test failures to work through.
Comment 4 Kentaro Hara 2012-11-20 17:09:58 PST 
Created attachment 175309 [details]
Fixed test failures
Comment 5 WebKit Review Bot 2012-11-20 17:58:50 PST 
Comment on attachment 175309 [details]
Fixed test failures

Clearing flags on attachment: 175309

Committed r135338: <http://trac.webkit.org/changeset/135338>
Comment 6 WebKit Review Bot 2012-11-20 17:58:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-11-21 14:49:31 PST 
Re-opened since this is blocked by bug 102981
Comment 8 Takeshi Yoshino 2013-04-08 23:54:48 PDT 
bug 102981 which reopened this automatically has been resolved.

I think it's ok to close this bug.