Bug 102803

Summary: [Qt] Zoom logic confused by page and pinch resize
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit2Assignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, kenneth, menard, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kenneth: review+

Allan Sandfeld Jensen
Reported 2012-11-20 05:00:08 PST
The zoom logic can act in very surprising ways after a page resize or a pinch zoom. The problem is for page resize that the zoom-out stack is not cleared, and for both pinch zoom and page resize that all later zooms are treated as ZoomIn even if they are zooming out, or trying to zoom back to the unzoomed page.
Attachments
Patch (7.68 KB, patch)
2012-11-20 05:04 PST, Allan Sandfeld Jensen 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-11-20 05:04:06 PST
Created attachment 175194 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-11-20 05:09:01 PST
Can this be tested with a qml unit test?
Allan Sandfeld Jensen
Comment 3 2012-11-20 05:16:17 PST
(In reply to comment #2) > Can this be tested with a qml unit test? Possibly, currently we have only very limited tests of double-tap to zoom. So I would start by adding tests of zoom-back, zoom-out and a lot of other behavior before this comes up.
Allan Sandfeld Jensen
Comment 4 2012-11-20 05:19:43 PST
Committed r135272: <http://trac.webkit.org/changeset/135272>
Note You need to log in before you can comment on or make changes to this bug.