Bug 102800

Summary: [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, dongseong.hwang, eric.carlson, feature-media-reviews, kenneth, menard, ossy, pierre.rossi, vestbo, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103073, 103074    
Bug Blocks: 99314    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Simon Hausmann 2012-11-20 04:33:25 PST 
In preparation for bug #99314 we should move all the code that depends on QtWidgets into a separate WebKitWidgets.a static library first and make sure
that the WebKit1.a static library is compiled without QtWidgets.
Comment 1 Simon Hausmann 2012-11-20 07:34:56 PST 
Created attachment 175217 [details]
Patch
Comment 2 Simon Hausmann 2012-11-20 07:35:18 PST 
Comment on attachment 175217 [details]
Patch

Clearing review, just want to run this through the EWS :)
Comment 3 WebKit Review Bot 2012-11-20 07:37:52 PST 
Attachment 175217 [details] did not pass style-queue:

Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:93:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:94:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:95:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:95:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:96:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:97:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:98:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:99:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:106:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:107:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:108:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:117:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:119:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:120:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:121:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:123:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:124:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:125:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:128:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:129:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:176:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:180:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebframe.h:120:  The parameter name "pageAdapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1138:  Declaration has space between type name and * in QWebPageAdapter *DumpRenderTree  [whitespace/declaration] [3]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1143:  Declaration has space between type name and * in QWebFrameAdapter *DumpRenderTree  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:231:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:358:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:53:  Declaration has space between type name and * in QGraphicsObject *parentItem  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:58:  Declaration has space between type name and * in QObject *QGraphicsWidgetPluginImpl  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebpage_p.h:24:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebpage_p.h:91:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:92:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:93:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:94:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:95:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:96:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:102:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:132:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:132:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:133:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:134:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage_p.h:134:  The parameter name "item" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:97:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:143:  Declaration has space between type name and * in QWebFrameAdapter *QWebFrameAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:194:  Declaration has space between type name and * in QWebFrameAdapter *QWebFrameAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.h:31:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.h:33:  The parameter name "undoStep" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:74:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:79:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:88:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:230:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:233:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:236:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1194:  Declaration has space between type name and * in QWebPageAdapter *newPage  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/GeolocationPermissionClientQt.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebframe_p.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:46:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:84:  The parameter name "inspectorClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/UndoStepQt.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QtPluginWidgetAdapter.h:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:33:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:45:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/Api/qwebsettings.cpp:46:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:35:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:85:  The parameter name "webFrame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:85:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:24:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:34:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:39:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:207:  Declaration has space between type name and * in QObject *PageClientQWidget  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:366:  Declaration has space between type name and * in QObject *PageClientQGraphicsWidget  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.cpp:20:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:68:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:87:  The parameter name "req" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:87:  The parameter name "operation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:92:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:98:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:103:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:104:  The parameter name "frameData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp:445:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit/qt/WebCoreSupport/DragClientQt.h:37:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:67:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:407:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:408:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:497:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:521:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:729:  Declaration has space between type name and * in QWebFullScreenVideoHandler *ChromeClientQt  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:770:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/InitWebKitQt.cpp:22:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/WebEventConversion.h:23:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:64:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:78:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:79:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:80:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:81:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:82:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:83:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:85:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:121:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:121:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:151:  The parameter name "manager" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage.cpp:108:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebpage.cpp:379:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/Api/qwebpage.cpp:518:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit/qt/Api/qwebpage.cpp:3461:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/Api/qwebpage.cpp:3469:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/Api/qwebpage.cpp:3477:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/Api/qwebpage.cpp:3485:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:28:  AlphabeticalFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/platform/qt/QWebPageClient...." exit_code: 1
 sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:83:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:101:  Declaration has space between type name and * in QNetworkAccessManager *QWebPageAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:27:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:66:  Declaration has space between type name and * in QObject *QWidgetPluginImpl  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:65:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:82:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:101:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 146 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2012-11-20 07:44:26 PST 
Comment on attachment 175217 [details]
Patch

Attachment 175217 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14905628
Comment 5 Early Warning System Bot 2012-11-20 07:46:05 PST 
Comment on attachment 175217 [details]
Patch

Attachment 175217 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14912643
Comment 6 Simon Hausmann 2012-11-20 08:14:49 PST 
Created attachment 175224 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-20 08:19:15 PST 
Attachment 175224 [details] did not pass style-queue:

Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:93:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:94:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:95:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:95:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:96:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:97:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:98:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:99:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:106:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:107:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:108:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:117:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:119:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:120:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:121:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:123:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:124:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:125:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:128:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:129:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:176:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:180:  The parameter name "adapter" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:231:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:358:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:53:  Declaration has space between type name and * in QGraphicsObject *parentItem  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.cpp:58:  Declaration has space between type name and * in QObject *QGraphicsWidgetPluginImpl  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:97:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:143:  Declaration has space between type name and * in QWebFrameAdapter *QWebFrameAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:194:  Declaration has space between type name and * in QWebFrameAdapter *QWebFrameAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.h:31:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.h:33:  The parameter name "undoStep" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:74:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:79:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:88:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:230:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:233:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:236:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1194:  Declaration has space between type name and * in QWebPageAdapter *newPage  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/GeolocationPermissionClientQt.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:46:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:84:  The parameter name "inspectorClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/UndoStepQt.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QtPluginWidgetAdapter.h:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:33:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.h:45:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:35:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:85:  The parameter name "webFrame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:85:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:24:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:34:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QGraphicsWidgetPluginImpl.h:39:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:207:  Declaration has space between type name and * in QObject *PageClientQWidget  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:366:  Declaration has space between type name and * in QObject *PageClientQGraphicsWidget  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWebUndoCommand.cpp:20:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:68:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:87:  The parameter name "req" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:87:  The parameter name "operation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:92:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:98:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:103:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.h:104:  The parameter name "frameData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp:445:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit/qt/WebCoreSupport/DragClientQt.h:37:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:67:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:407:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:408:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:497:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:521:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:729:  Declaration has space between type name and * in QWebFullScreenVideoHandler *ChromeClientQt  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:770:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/InitWebKitQt.cpp:22:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/WebEventConversion.h:23:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:23:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:64:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:78:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:79:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:80:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:81:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:82:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:83:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:85:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:121:  The parameter name "frame" adds no informaFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/platform/qt/QWebPageClient...." exit_code: 1
tion, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:121:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:151:  The parameter name "manager" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebpage.cpp:97:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:83:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:101:  Declaration has space between type name and * in QNetworkAccessManager *QWebPageAdapter  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:27:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/qt/WebCoreSupport/QWidgetPluginImpl.cpp:66:  Declaration has space between type name and * in QObject *QWidgetPluginImpl  [whitespace/declaration] [3]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:65:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:82:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:101:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 121 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Simon Hausmann 2012-11-21 01:24:31 PST 
Created attachment 175369 [details]
Patch
Comment 9 Pierre Rossi 2012-11-21 06:32:19 PST 
Comment on attachment 175369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175369&action=review

> Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp:201
> +    emit m_page->respondToChangedContents();

remove "emit"

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:-207
> -    , m_webFrame(0)

this shouldn't go away

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:-262
> -    ASSERT(m_webFrame);

Ditto.

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:229
> +    // FIXME: Remove virtual keyword once FrameLoaderClienQt has moved from WKWidgets to WK1.

Please do fix me...

> Source/WebKit/qt/WebCoreSupport/UndoStepQt.cpp:140
>  // vim: ts=4 sw=4 et

that should be at the bottom of the file still...

> Source/WebKit2/qt/MainQt.cpp:45
> +#if !defined(QT_NO_WIDGETS)

do we have another define for that ?
Comment 10 Simon Hausmann 2012-11-22 03:44:51 PST 
Created attachment 175642 [details]
Patch
Comment 11 Simon Hausmann 2012-11-22 05:44:41 PST 
Comment on attachment 175642 [details]
Patch

Reviewing locally with Tor Arne in the office
Comment 12 Simon Hausmann 2012-11-22 06:35:09 PST 
Committed r135515: <http://trac.webkit.org/changeset/135515>
Comment 13 Csaba Osztrogonác 2012-11-22 08:57:39 PST 
New bugs to
- fix the 3-3 failing/crashing test: https://bugs.webkit.org/show_bug.cgi?id=103073
- fix the Windows build: https://bugs.webkit.org/show_bug.cgi?id=103074
Comment 14 Dongseong Hwang 2012-12-02 16:16:00 PST 
When I run layout test on Qt WK2 and EFL WK2, I encounters crash.
Do you think it is related to this bug?

crash log for WebProcess (pid <unknown>):
STDOUT: <empty>
STDERR: /media/WDDisk/workspace/WebKit/WebKit/WebKitBuild/qt5/Release/bin/QtWebProcess: symbol lookup error: /media/WDDisk/workspace/WebKit/WebKit/WebKitBuild/qt5/Release/lib/libWebKitWidgets.so.1: undefined symbol: _ZN6WebKit28setWebKitWidgetsInitCallbackEPFPN7WebCore12QStyleFacadeEPNS0_4PageEE
Comment 15 Dongseong Hwang 2012-12-02 16:18:28 PST 
(In reply to comment #14)
> When I run layout test on Qt WK2 and EFL WK2, I encounters crash.
> Do you think it is related to this bug?
> 
> crash log for WebProcess (pid <unknown>):
> STDOUT: <empty>
> STDERR: /media/WDDisk/workspace/WebKit/WebKit/WebKitBuild/qt5/Release/bin/QtWebProcess: symbol lookup error: /media/WDDisk/workspace/WebKit/WebKit/WebKitBuild/qt5/Release/lib/libWebKitWidgets.so.1: undefined symbol: _ZN6WebKit28setWebKitWidgetsInitCallbackEPFPN7WebCore12QStyleFacadeEPNS0_4PageEE

I tested like this.
> ./new-run-webkit-tests --qt -2 compositing/backings

And the results


Found 4 tests; running 4, skipping 0.
Running 1 WebKitTestRunner over 1 shard.

[1/4] compositing/backing/no-backing-for-clip-overlap.html failed unexpectedly (WebProcess crashed)
[2/4] compositing/backing/no-backing-for-clip.html failed unexpectedly (WebProcess crashed)
[3/4] compositing/backing/no-backing-for-perspective.html failed unexpectedly (WebProcess crashed)
[4/4] compositing/backing/no-backing-foreground-layer.html failed unexpectedly (WebProcess crashed)
Comment 16 Csaba Osztrogonác 2012-12-03 03:30:55 PST 
I don't think so ... These tests pass on Qt-WK2 bots.
Comment 17 Pierre Rossi 2012-12-03 04:29:34 PST 
(In reply to comment #16)
> I don't think so ... These tests pass on Qt-WK2 bots.

No worries there: we had a quick chat on IRC yesterday, and a clean build was required for things to work again. :)