Bug 102792

Summary: Web Inspector: Script Profiler: Make profiler output typed.
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, caseq, eustas.bug, eustas, gtk-ews, haraken, japhet, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 103042, 104545    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description eustas.bug 2012-11-20 04:06:20 PST 
Currently fields "head" and "bottomUpHead" of Profile object
returned by Profiler.getProfile is untyped (type = object).

That's not good both for client side (protocol users may
only guess on output content) and backend side (field names
are hardcoded in source code).

This patch defines "head" and "bottomUpHead" to be of new
"ProfileNode" type and updates serialization code to use
builders to create output.
Comment 1 eustas.bug 2012-11-20 04:10:33 PST 
Created attachment 175186 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-20 23:56:28 PST 
Comment on attachment 175186 [details]
Patch

We should first split Heap snapshots and CPU profiles. Currently they are all described by Profiler.Profile object in the protocol which seems wrong and makes front-end implementation too complicated.
Comment 3 Eugene Klyuchnikov 2013-01-29 05:38:56 PST 
Created attachment 185223 [details]
Patch
Comment 4 Eugene Klyuchnikov 2013-01-29 05:43:47 PST 
Created attachment 185225 [details]
Patch
Comment 5 kov's GTK+ EWS bot 2013-01-29 08:27:57 PST 
Comment on attachment 185225 [details]
Patch

Attachment 185225 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16200205
Comment 6 Yury Semikhatsky 2013-01-30 07:35:16 PST 
Comment on attachment 185225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185225&action=review

> Source/WebCore/bindings/v8/ScriptProfile.h:38
> +#if ENABLE(INSPECTOR)

Can we hide the whole file behind the guard?
Comment 7 Eugene Klyuchnikov 2013-01-30 07:46:44 PST 
(In reply to comment #6)
> (From update of attachment 185225 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185225&action=review
> 
> > Source/WebCore/bindings/v8/ScriptProfile.h:38
> > +#if ENABLE(INSPECTOR)
> 
> Can we hide the whole file behind the guard?

Not sure. Collecting profile is a console feature.
Comment 8 WebKit Review Bot 2013-01-30 08:17:09 PST 
Comment on attachment 185225 [details]
Patch

Clearing flags on attachment: 185225

Committed r141273: <http://trac.webkit.org/changeset/141273>
Comment 9 WebKit Review Bot 2013-01-30 08:17:13 PST 
All reviewed patches have been landed.  Closing bug.