Bug 102773

Summary: [EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
Product: WebKit Reporter: Jaehun Lim <ljaehun.lim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jaehun Lim
Reported 2012-11-19 23:29:23 PST
PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.
Attachments
Patch (1.33 KB, patch)
2012-11-19 23:31 PST, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2012-11-21 14:45 PST, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jaehun Lim
Comment 1 2012-11-19 23:31:35 PST
Created attachment 175154 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-11-20 02:01:00 PST
Comment on attachment 175154 [details] Patch Looks OK.
Laszlo Gombos
Comment 3 2012-11-21 13:50:09 PST
Comment on attachment 175154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175154&action=review Overall looks good. > Source/WebKit2/ChangeLog:3 > + [EFL][WK2] Remove #include #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp Please remove the double #include.
Jaehun Lim
Comment 4 2012-11-21 14:45:39 PST
Created attachment 175525 [details] Patch
WebKit Review Bot
Comment 5 2012-11-21 16:21:23 PST
Comment on attachment 175525 [details] Patch Clearing flags on attachment: 175525 Committed r135453: <http://trac.webkit.org/changeset/135453>
WebKit Review Bot
Comment 6 2012-11-21 16:21:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.