Bug 102766

Summary: Week picker width is too small
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-11-19 22:03:42 PST
Week picker width is too small because we calculate desired window width with 7 columns.
Attachments
Patch (112.01 KB, patch)
2012-11-19 22:14 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (113.14 KB, patch)
2012-11-20 04:04 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-11-19 22:14:21 PST
Created attachment 175139 [details] Patch
Kent Tamura
Comment 2 2012-11-19 22:37:56 PST
Comment on attachment 175139 [details] Patch I think it's better to give a different width to the week number column instead of the same column width with day-of-week columns. - maxCellWidth computation should omit headers[0]. - daysAreaEnd computation should add headers[0].offsetWidth. - should set headers[0].style.minWidth = headers[0].offsetWidth + 'px';
WebKit Review Bot
Comment 3 2012-11-19 22:58:17 PST
Comment on attachment 175139 [details] Patch Attachment 175139 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14908447 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Keishi Hattori
Comment 4 2012-11-20 04:04:14 PST
Created attachment 175184 [details] Patch
Kent Tamura
Comment 5 2012-11-20 04:19:30 PST
Comment on attachment 175184 [details] Patch Looks good
WebKit Review Bot
Comment 6 2012-11-20 06:02:49 PST
Comment on attachment 175184 [details] Patch Clearing flags on attachment: 175184 Committed r135274: <http://trac.webkit.org/changeset/135274>
WebKit Review Bot
Comment 7 2012-11-20 06:02:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.