Bug 102766 - Week picker width is too small
Summary: Week picker width is too small
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 22:03 PST by Keishi Hattori
Modified: 2012-11-20 06:02 PST (History)
3 users (show)

See Also:


Attachments
Patch (112.01 KB, patch)
2012-11-19 22:14 PST, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (113.14 KB, patch)
2012-11-20 04:04 PST, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-11-19 22:03:42 PST
Week picker width is too small because we calculate desired window width with 7 columns.
Comment 1 Keishi Hattori 2012-11-19 22:14:21 PST
Created attachment 175139 [details]
Patch
Comment 2 Kent Tamura 2012-11-19 22:37:56 PST
Comment on attachment 175139 [details]
Patch

I think it's better to give a different width to the week number column instead of the same column width with day-of-week columns.

- maxCellWidth computation should omit headers[0].
- daysAreaEnd computation should add headers[0].offsetWidth.
- should set headers[0].style.minWidth = headers[0].offsetWidth + 'px';
Comment 3 WebKit Review Bot 2012-11-19 22:58:17 PST
Comment on attachment 175139 [details]
Patch

Attachment 175139 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14908447

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 4 Keishi Hattori 2012-11-20 04:04:14 PST
Created attachment 175184 [details]
Patch
Comment 5 Kent Tamura 2012-11-20 04:19:30 PST
Comment on attachment 175184 [details]
Patch

Looks good
Comment 6 WebKit Review Bot 2012-11-20 06:02:49 PST
Comment on attachment 175184 [details]
Patch

Clearing flags on attachment: 175184

Committed r135274: <http://trac.webkit.org/changeset/135274>
Comment 7 WebKit Review Bot 2012-11-20 06:02:54 PST
All reviewed patches have been landed.  Closing bug.