Bug 102756

Summary: [Refacotring] Remove WebCore::isInsertionPoint(Node*)
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ojan, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-11-19 18:24:33 PST
This is a follow-up for Bug 100738. Now that WebCore::isInsertionPoint(Node*) does nothing. We can remove this.
Attachments
Patch (6.40 KB, patch)
2012-11-19 18:27 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.41 KB, patch)
2012-11-19 21:52 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-19 18:27:52 PST
Created attachment 175106 [details] Patch
WebKit Review Bot
Comment 2 2012-11-19 21:15:34 PST
Comment on attachment 175106 [details] Patch Attachment 175106 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14899452 New failing tests: fast/dom/shadow/content-reprojection-fallback-reprojection.html fast/dom/shadow/content-child-whitespace-between-span.html fast/dom/shadow/composed-shadow-tree-walker.html fast/dom/shadow/content-element-distributed-nodes.html fast/dom/shadow/focus-navigation-with-distributed-nodes.html fast/dom/shadow/focus-navigation.html fast/dom/shadow/content-reprojection-complex.html fast/dom/shadow/events-stopped-at-shadow-boundary.html fast/dom/shadow/content-element-select-dynamic.html fast/dom/shadow/athost-atrules.html fast/dom/shadow/distribution-className-modified.html fast/dom/shadow/content-element-move.html fast/dom/shadow/content-reprojection-dynamic.html fast/dom/shadow/content-reprojection-fallback.html fast/dom/shadow/content-reprojection-shadow.html fast/dom/shadow/create-content-element.html fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html fast/dom/shadow/content-element-outside-shadow-style.html fast/dom/shadow/distribution-id-modified.html fast/dom/shadow/content-reprojection-fallback-crash.html editing/shadow/delete-list-in-shadow.html fast/block/block-remove-child-delete-line-box-crash.html fast/css/style-scoped/style-scoped-in-shadow.html editing/shadow/selection-of-shadowroot.html fast/dom/shadow/content-reprojection-order.html fast/dom/shadow/distribution-attribute-modified.html editing/shadow/breaking-editing-boundaries.html fast/dom/shadow/content-element-renderers.html fast/dom/shadow/content-after-style.html fast/dom/shadow/content-element-includer.html
Shinya Kawanaka
Comment 3 2012-11-19 21:45:09 PST
So many tests are failing... why? :-(
Shinya Kawanaka
Comment 4 2012-11-19 21:52:06 PST
Created attachment 175137 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-11-19 22:10:05 PST
Comment on attachment 175137 [details] Patch for landing Clearing flags on attachment: 175137 Committed r135251: <http://trac.webkit.org/changeset/135251>
WebKit Review Bot
Comment 6 2012-11-19 22:10:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.