Bug 102754

Summary: In CodeGenerator.pm we should rename $dataNode to $interface
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-11-19 17:43:15 PST
This is a final patch for the iteration. $dataNode is misnamed. It should be $interface.
Attachments
Patch (8.58 KB, patch)
2012-11-19 17:47 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-19 17:47:37 PST
Created attachment 175101 [details] Patch
WebKit Review Bot
Comment 2 2012-11-19 19:05:22 PST
Comment on attachment 175101 [details] Patch Attachment 175101 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14909435 New failing tests: fast/dom/shadow/shadow-dom-event-dispatching.html
WebKit Review Bot
Comment 3 2012-11-19 19:16:02 PST
Comment on attachment 175101 [details] Patch Clearing flags on attachment: 175101 Committed r135234: <http://trac.webkit.org/changeset/135234>
WebKit Review Bot
Comment 4 2012-11-19 19:16:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.