Bug 102729 – [CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured

• Component: CSS
• Status: RESOLVED FIXED

[Hans Muller]

Created attachment 175063 [details]
shape-inside-polygon-rectangle.html screenshot

The results of these ref-tests are manifestly incorrect, as can be seen in in the attached screenshot of LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html.  The following tests all share the same problem:

shape-inside-polygon-rectangle.html
shape-inside-vertical-text.html
shape-inside-multiple-blocks-vertical.html

The results are only obviously incorrect in the first case.  The source of the problem appears to be (just) a mixup between CSS padding, which lists top, right, bottom left, and the CSS top,left attributes that absolutely position the tests' border element.

[Hans Muller]

Created attachment 175220 [details]
Patch

Corrects shape-inside-polygon-rectangle.html and shape-inside-vertical-text.html.  The last test, shape-inside-multiple-blocks-vertical.html, was already correct.

The original tests were attempting to create a 2 pixel wide margin between the shape-inside text and the blue border outline.  The new versions of the tests use five pixels since that seemed a little simpler.

[WebKit Review Bot]

Comment on attachment 175220 [details]
Patch

Clearing flags on attachment: 175220

Committed r135296: <http://trac.webkit.org/changeset/135296>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.