Bug 102718

Summary: Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: REOPENED ---    
Severity: Normal CC: gtk-ews, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on: 102725    
Bug Blocks: 98537    
Attachments:
Description Flags
Patch v1 sam: review+, eflews.bot: commit-queue-

Description Brady Eidson 2012-11-19 14:51:13 PST 
Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo

It should also become a free function as it doesn't depend on being a member of any class.
Comment 1 Brady Eidson 2012-11-19 14:55:16 PST 
Created attachment 175046 [details]
Patch v1
Comment 2 Brady Eidson 2012-11-19 14:59:28 PST 
http://trac.webkit.org/changeset/135201
Comment 3 WebKit Review Bot 2012-11-19 15:34:55 PST 
Re-opened since this is blocked by bug 102725
Comment 4 EFL EWS Bot 2012-11-19 15:54:13 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14913372
Comment 5 Early Warning System Bot 2012-11-19 16:00:42 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14911360
Comment 6 Build Bot 2012-11-19 16:30:11 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14905366
Comment 7 kov's GTK+ EWS bot 2012-11-19 16:30:55 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14911367
Comment 8 Brady Eidson 2012-11-19 17:45:53 PST 
Wow.  Completely hosed this one.  Backing out.
Comment 9 Brady Eidson 2012-11-19 17:46:36 PST 
Already backed out, nm.  (I wish those messages went in the original bug, and not the bug that generated the rollout)
Comment 10 Brady Eidson 2012-11-19 17:46:59 PST 
(In reply to comment #9)
> Already backed out, nm.  (I wish those messages went in the original bug, and not the bug that generated the rollout)

Errr... original bug *in addition to* the bug generating the rollout.