Bug 102718

Summary: Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: REOPENED    
Severity: Normal CC: gtk-ews, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on: 102725    
Bug Blocks: 98537    
Attachments:
Description Flags
Patch v1 sam: review+, eflews.bot: commit-queue-

Brady Eidson
Reported 2012-11-19 14:51:13 PST
Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo It should also become a free function as it doesn't depend on being a member of any class.
Attachments
Patch v1 (13.10 KB, patch)
2012-11-19 14:55 PST, Brady Eidson 		sam: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-11-19 14:55:16 PST
Created attachment 175046 [details] Patch v1
Brady Eidson
Comment 2 2012-11-19 14:59:28 PST
http://trac.webkit.org/changeset/135201
WebKit Review Bot
Comment 3 2012-11-19 15:34:55 PST
Re-opened since this is blocked by bug 102725
EFL EWS Bot
Comment 4 2012-11-19 15:54:13 PST
Comment on attachment 175046 [details] Patch v1 Attachment 175046 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14913372
Early Warning System Bot
Comment 5 2012-11-19 16:00:42 PST
Comment on attachment 175046 [details] Patch v1 Attachment 175046 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14911360
Build Bot
Comment 6 2012-11-19 16:30:11 PST
Comment on attachment 175046 [details] Patch v1 Attachment 175046 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14905366
kov's GTK+ EWS bot
Comment 7 2012-11-19 16:30:55 PST
Comment on attachment 175046 [details] Patch v1 Attachment 175046 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14911367
Brady Eidson
Comment 8 2012-11-19 17:45:53 PST
Wow. Completely hosed this one. Backing out.
Brady Eidson
Comment 9 2012-11-19 17:46:36 PST
Already backed out, nm. (I wish those messages went in the original bug, and not the bug that generated the rollout)
Brady Eidson
Comment 10 2012-11-19 17:46:59 PST
(In reply to comment #9) > Already backed out, nm. (I wish those messages went in the original bug, and not the bug that generated the rollout) Errr... original bug *in addition to* the bug generating the rollout.
Note You need to log in before you can comment on or make changes to this bug.