Bug 102713

Summary: IndexedDB: last setVersion excision batch
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94972, 105559    
Attachments:
Description Flags
Patch none

David Grogan
Reported 2012-11-19 14:14:57 PST
IndexedDB: last setVersion excision batch
Attachments
Patch (24.49 KB, patch)
2012-11-19 14:24 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-11-19 14:24:29 PST
Created attachment 175041 [details] Patch
David Grogan
Comment 2 2012-11-19 14:27:48 PST
Josh, there are 2 deletions and 2 conversions. Could you take a look? There are three outstanding tests but they have individual bugs.
Joshua Bell
Comment 3 2012-11-19 17:05:11 PST
Comment on attachment 175041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175041&action=review lgtm > LayoutTests/storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js:36 > + // In multi-process ports h2 can erroneously get a blocked event after Weird - is that another case of wkbug.com/92674 "Delete requests sometimes receive two blocked events" ?
David Grogan
Comment 4 2012-11-19 17:18:58 PST
Comment on attachment 175041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175041&action=review >> LayoutTests/storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js:36 >> + // In multi-process ports h2 can erroneously get a blocked event after > > Weird - is that another case of wkbug.com/92674 "Delete requests sometimes receive two blocked events" ? Yeah. This request is for an open rather than a delete but it's the same behavior.
David Grogan
Comment 5 2012-11-19 17:19:22 PST
Tony, could you review this?
WebKit Review Bot
Comment 6 2012-11-19 18:03:06 PST
Comment on attachment 175041 [details] Patch Clearing flags on attachment: 175041 Committed r135223: <http://trac.webkit.org/changeset/135223>
WebKit Review Bot
Comment 7 2012-11-19 18:03:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.