Bug 102704

Summary: [EFL] Add fallback for WebkitTestRunner if opengl is not available.
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: WebKit EFLAssignee: Viatcheslav Ostapenko <ostap73>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, lucas.de.marchi, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Viatcheslav Ostapenko
Reported 2012-11-19 12:18:14 PST
Crash: ASSERTION FAILED: m_ptr /home/sl/work/webkit/Source/WTF/wtf/OwnPtr.h(72) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = WTR::TestInvocation; WTF::OwnPtr<T>::PtrType = WTR::TestInvocation*; WTF::OwnPtr<T>::ValueType = WTR::TestInvocation] 1 0x80666be WTF::OwnPtr<WTR::TestInvocation>::operator->() const 2 0x8062c14 WTR::TestController::run() 3 0x8060a0d WTR::TestController::TestController(int, char const**) 4 0x8075b77 main 5 0xb05304d3 __libc_start_main 6 0x805f611
Attachments
Patch (1.60 KB, patch)
2012-11-19 12:32 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.69 KB, patch)
2012-11-19 21:07 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2012-11-19 12:32:01 PST
Created attachment 175024 [details] Patch
Yael
Comment 2 2012-11-19 14:45:53 PST
LGTM
Laszlo Gombos
Comment 3 2012-11-19 17:01:08 PST
Comment on attachment 175024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175024&action=review > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:36 > + ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0); I would add a comment here // Graceful fallback to software rendering if evas_gl engine is not available.
Viatcheslav Ostapenko
Comment 4 2012-11-19 21:07:48 PST
Created attachment 175129 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-11-19 21:35:24 PST
Comment on attachment 175129 [details] Patch for landing Clearing flags on attachment: 175129 Committed r135246: <http://trac.webkit.org/changeset/135246>
WebKit Review Bot
Comment 6 2012-11-19 21:35:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.