Bug 102674

Summary: [EFL][WK2] Remove unnecessary #include in API test
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, laszlo.gombos, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2012-11-19 04:29:16 PST
Removed #include <gtest/gtest.h> line in the API test cases as EWK2UnitTestBase.h already included it.
Attachments
Patch (6.31 KB, patch)
2012-11-19 04:32 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (16.50 KB, patch)
2012-11-20 04:47 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-11-19 04:32:44 PST
Created attachment 174952 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-11-19 07:36:02 PST
LGTM.
Laszlo Gombos
Comment 3 2012-11-19 11:42:10 PST
It seems to me that there are other header files (e.g. EWebKit2.h) that are included in EWK2UnitTestBase.h as well. Why is <gtest.h> singled out? I think for consistency either all duplicated should be removed or leave it as it is.
Jinwoo Song
Comment 4 2012-11-20 00:57:00 PST
(In reply to comment #3) > It seems to me that there are other header files (e.g. EWebKit2.h) that are included in EWK2UnitTestBase.h as well. Why is <gtest.h> singled out? > > I think for consistency either all duplicated should be removed or leave it as it is. I'll removed other duplicated header files and upload a new patch. :)
Jinwoo Song
Comment 5 2012-11-20 04:47:37 PST
Created attachment 175191 [details] Patch
Laszlo Gombos
Comment 6 2012-11-20 21:15:12 PST
Comment on attachment 175191 [details] Patch r=me.
WebKit Review Bot
Comment 7 2012-11-20 21:32:46 PST
Comment on attachment 175191 [details] Patch Clearing flags on attachment: 175191 Committed r135349: <http://trac.webkit.org/changeset/135349>
WebKit Review Bot
Comment 8 2012-11-20 21:32:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.