Bug 102668

Summary:

[GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, mrobinson, webkit.review.bot

Priority:

Keywords:

Gtk, Regression

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	pnormand: review+

Carlos Garcia Campos

Reported 2012-11-19 02:22:37 PST

Change in r134586 is not the problem, it indeed fixes the FIXME we have in the tests. The problem is that we were assuming that when no geometry is given to window.open() the default window rect is empty. This is not true anymore after r134586.

Attachments
Patch (3.83 KB, patch) 2012-11-19 02:29 PST, Carlos Garcia Campos	pnormand: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2012-11-19 02:29:16 PST

Created attachment 174927 [details] Patch

WebKit Review Bot

Comment 2 2012-11-19 02:32:15 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 3 2012-11-19 03:23:27 PST

Committed r135135: <http://trac.webkit.org/changeset/135135>

Note You need to log in before you can comment on or make changes to this bug.