Bug 102658

Summary: Add PROXIMITY_EVENTS feature
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebKit Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dbates, gyuyoung.kim, haraken, rakuco, roger_fong, vestbo, vimff0, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 92837    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Kihong Kwon 2012-11-19 01:22:49 PST 
Add PROXIMITY_EVENTS feature to all ports.
Comment 1 Kihong Kwon 2012-11-19 02:16:47 PST 
Created attachment 174922 [details]
Patch
Comment 2 Build Bot 2012-11-19 02:52:42 PST 
Comment on attachment 174922 [details]
Patch

Attachment 174922 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14911141
Comment 3 Kihong Kwon 2012-11-19 03:06:55 PST 
Created attachment 174933 [details]
Patch
Comment 4 Kentaro Hara 2012-11-19 03:19:36 PST 
Comment on attachment 174933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174933&action=review

Looks OK. Did you locally confirm the behavior with PROXIMITY_EVENTS enabled?

> Source/JavaScriptCore/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for JavaScriptCore.

Typo: feature

> Source/WebCore/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebCorei and GNU make.

Typo: feature
Typo: WebCore

> Source/WebKit/chromium/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to chromium port.

Typo: feature

> Source/WebKit/mac/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebKit.

Ditto.

> Source/WebKit2/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebKit2.

Ditto.

> Tools/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to FeatureList and qmake.

Ditto.

> ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to cmake.

Ditto.

> WebKitLibraries/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to win and win-cairo prot.

Ditto.
Comment 5 Kihong Kwon 2012-11-19 04:01:18 PST 
(In reply to comment #4)
> (From update of attachment 174933 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174933&action=review
> 
> Looks OK. Did you locally confirm the behavior with PROXIMITY_EVENTS enabled?

Yes, I already checked that.
And I will fix all my typo.
Thank you.
Comment 6 Kentaro Hara 2012-11-19 04:05:57 PST 
Comment on attachment 174933 [details]
Patch

OK, thanks for the fix!
Comment 7 Kihong Kwon 2012-11-19 04:06:42 PST 
Created attachment 174943 [details]
Patch
Comment 8 Kihong Kwon 2012-11-19 07:14:49 PST 
Comment on attachment 174943 [details]
Patch

Thank you for reviewing. haraken. :)
Comment 9 WebKit Review Bot 2012-11-19 07:43:32 PST 
Comment on attachment 174943 [details]
Patch

Clearing flags on attachment: 174943

Committed r135159: <http://trac.webkit.org/changeset/135159>
Comment 10 WebKit Review Bot 2012-11-19 07:43:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Roger Fong 2013-01-08 18:48:44 PST 
I noticed that in this patch the feature defines flag for windows is set to false (Value = "")
Is the proximity events feature not supposed to work on Windows?

I also noticed that there are 9 new failing proximity tests 
http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r139050%20(31331)/results.html

They still fail if I enable the feature.
Comment 12 Kihong Kwon 2013-01-08 21:22:47 PST 
(In reply to comment #11)
> I noticed that in this patch the feature defines flag for windows is set to false (Value = "")
> Is the proximity events feature not supposed to work on Windows?
> 
> I also noticed that there are 9 new failing proximity tests 
> http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r139050%20(31331)/results.html
> 
> They still fail if I enable the feature.

Proximity event test cases can be passed on the efl wk2 until now.
If Windows port support proximity events, someone need to implement window port layer for Proximity Events.