Bug 102649

Summary: webaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionObserver::scriptExecutionContext().
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web AudioAssignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, eric.carlson, feature-media-reviews, haraken, kbr, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Ilya Tikhonovsky
Reported 2012-11-18 23:14:13 PST
AudioContext uses m_document only as a pointer to ScriptExecutionContext. It could be safely replaced with ContextDestructionObserver::m_scriptExecutionContext. The lifetime of m_scriptExecutionContext is slightly different but it could be adjusted by m_isStopScheduled flag.
Attachments
Patch (8.35 KB, patch)
2012-11-18 23:18 PST, Ilya Tikhonovsky 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-11-18 23:18:50 PST
Created attachment 174900 [details] Patch
Adam Barth
Comment 2 2012-11-18 23:40:33 PST
Comment on attachment 174900 [details] Patch Thanks!
Adam Barth
Comment 3 2012-11-18 23:41:00 PST
*** Bug 99242 has been marked as a duplicate of this bug. ***
Ilya Tikhonovsky
Comment 4 2012-11-18 23:43:19 PST
Committed r135116: <http://trac.webkit.org/changeset/135116>
Kentaro Hara
Comment 5 2012-11-19 05:35:21 PST
Reverted r135116 for reason: Revert this patch to revert r135111, which caused crashes in several layout tests Committed r135144: <http://trac.webkit.org/changeset/135144>
Ilya Tikhonovsky
Comment 6 2012-11-19 07:26:47 PST
Committed r135156: <http://trac.webkit.org/changeset/135156>
Note You need to log in before you can comment on or make changes to this bug.