Bug 102649 - webaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionObserver::scriptExecutionContext().
Summary: webaudio: clean-up. Replace AudioContext::m_document member with ContextDestr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
: 99242 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-18 23:14 PST by Ilya Tikhonovsky
Modified: 2012-11-19 07:26 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2012-11-18 23:18 PST, Ilya Tikhonovsky 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-11-18 23:14:13 PST 
AudioContext uses m_document only as a pointer to ScriptExecutionContext.
It could be safely replaced with ContextDestructionObserver::m_scriptExecutionContext.
The lifetime of m_scriptExecutionContext is slightly different but it could be adjusted by m_isStopScheduled flag.
Comment 1 Ilya Tikhonovsky 2012-11-18 23:18:50 PST 
Created attachment 174900 [details]
Patch
Comment 2 Adam Barth 2012-11-18 23:40:33 PST 
Comment on attachment 174900 [details]
Patch

Thanks!
Comment 3 Adam Barth 2012-11-18 23:41:00 PST 
*** Bug 99242 has been marked as a duplicate of this bug. ***
Comment 4 Ilya Tikhonovsky 2012-11-18 23:43:19 PST 
Committed r135116: <http://trac.webkit.org/changeset/135116>
Comment 5 Kentaro Hara 2012-11-19 05:35:21 PST 
Reverted r135116 for reason:

Revert this patch to revert r135111, which caused crashes in several layout tests

Committed r135144: <http://trac.webkit.org/changeset/135144>
Comment 6 Ilya Tikhonovsky 2012-11-19 07:26:47 PST 
Committed r135156: <http://trac.webkit.org/changeset/135156>