Bug 102613

Summary: [GTK] REGRESSION(r134955): Plugins are broken due to unresolved symbol in plugin process
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix the build
none
Patch none

Carlos Garcia Campos
Reported 2012-11-18 10:06:44 PST
See http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/31084/steps/API%20tests/logs/stdio plugins tests started to fail. The problem is an unresolved symbol in plugin process see: $ Programs/WebKitPluginProcess -scanPlugin TestNetscapePlugin/libtestnetscapeplugin.la Programs/.libs/lt-WebKitPluginProcess: symbol lookup error: Programs/.libs/lt-WebKitPluginProcess: undefined symbol: SECRET_SCHEMA_COMPAT_NETWORK
Attachments
Fix the build (1.11 KB, patch)
2012-11-19 12:37 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2012-11-19 13:30 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-11-19 08:32:06 PST
Thanks for reporting this. We probably just need to add LIBSECRET_LIBS to Programs_WebKitPluginProcess_LDADD.
Martin Robinson
Comment 2 2012-11-19 12:37:07 PST
Created attachment 175026 [details] Fix the build
WebKit Review Bot
Comment 3 2012-11-19 13:25:15 PST
Comment on attachment 175026 [details] Fix the build Rejecting attachment 175026 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14905315
Martin Robinson
Comment 4 2012-11-19 13:30:42 PST
Created attachment 175035 [details] Patch
WebKit Review Bot
Comment 5 2012-11-19 14:10:17 PST
Comment on attachment 175035 [details] Patch Clearing flags on attachment: 175035 Committed r135195: <http://trac.webkit.org/changeset/135195>
WebKit Review Bot
Comment 6 2012-11-19 14:10:21 PST
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 7 2012-11-19 23:37:57 PST
Thanks!
Note You need to log in before you can comment on or make changes to this bug.