Bug 102612

Summary: [chromium] add WebCursorInfo::imageScaleFactor
Product: WebKit Reporter: Rick Byers <rbyers>
Component: PlatformAssignee: Rick Byers <rbyers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99493    
Attachments:
Description Flags
Patch
none
Patch none

Description Rick Byers 2012-11-18 08:24:52 PST 
Splitting the chromium API change out from bug 99493 in order to decouple the webkit and chromium sides of this work.
Comment 1 Rick Byers 2012-11-18 08:27:42 PST 
Created attachment 174847 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-18 08:28:57 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-11-18 08:45:14 PST 
Comment on attachment 174847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review

> Source/WebKit/chromium/src/WebCursorInfo.cpp:44
> +    imageScaleFactor = 1;

You should initialize this variable in an initializer list, like you've done in the header.
Comment 4 Rick Byers 2012-11-18 09:22:12 PST 
Created attachment 174849 [details]
Patch
Comment 5 Rick Byers 2012-11-18 09:23:43 PST 
(In reply to comment #3)
> (From update of attachment 174847 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review
> 
> > Source/WebKit/chromium/src/WebCursorInfo.cpp:44
> > +    imageScaleFactor = 1;
> 
> You should initialize this variable in an initializer list, like you've done in the header.

Thanks.  I moved the initialization of all variables in this ctor to an initializer list in order to be consistent.
Comment 6 Adam Barth 2012-11-18 10:10:00 PST 
Comment on attachment 174849 [details]
Patch

great
Comment 7 Build Bot 2012-11-18 10:18:13 PST 
Comment on attachment 174849 [details]
Patch

Attachment 174849 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14893089

New failing tests:
inspector-protocol/nmi-webaudio.html
Comment 8 WebKit Review Bot 2012-11-18 10:47:05 PST 
Comment on attachment 174849 [details]
Patch

Clearing flags on attachment: 174849

Committed r135076: <http://trac.webkit.org/changeset/135076>
Comment 9 WebKit Review Bot 2012-11-18 10:47:08 PST 
All reviewed patches have been landed.  Closing bug.