Bug 102579

Summary: [mac] Enable scaled cursors
Product: WebKit Reporter: Rick Byers <rbyers>
Component: CSSAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, mitz, rbyers, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99493    
Bug Blocks:    
Attachments:
Description Flags
Patch dino: review+

Rick Byers
Reported 2012-11-16 20:53:34 PST
Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you? Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image.
Attachments
Patch (7.24 KB, patch)
2012-12-18 14:15 PST, Beth Dakin 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-11-26 11:34:57 PST
(In reply to comment #0) > Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used > > Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you? Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image. Sure, thank you.
Radar WebKit Bug Importer
Comment 2 2012-12-06 19:08:54 PST
<rdar://problem/12832295>
Beth Dakin
Comment 3 2012-12-18 14:15:08 PST
Created attachment 180023 [details] Patch
Dean Jackson
Comment 4 2012-12-18 14:19:13 PST
Comment on attachment 180023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180023&action=review > Source/WebCore/ChangeLog:10 > + defined, and we need to initialize m_imageScaleFactor in the Cursor constructors. > + * Configurations/FeatureDefines.xcconfig: Nit: blank line between here.
Beth Dakin
Comment 5 2012-12-18 14:27:34 PST
Thanks, Dean! http://trac.webkit.org/changeset/138069
Note You need to log in before you can comment on or make changes to this bug.