Bug 102578

Summary: Apply DeviceController as parent class of DeviceMotionController.
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebCore Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 96894    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Kihong Kwon 2012-11-16 20:50:54 PST 
DeviceOrientationController and DeviceMotionController have almost same structure.
Therefore DeviceController which is extracted as parent class of them is added.
In this patch, I apply DeviceController as parent class of DeviceMotionController.
Comment 1 Kihong Kwon 2012-11-16 21:15:01 PST 
Created attachment 174802 [details]
Patch
Comment 2 Kentaro Hara 2012-11-19 03:25:33 PST 
Comment on attachment 174802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review

Looks reasonable to me but I'm not familiar with this area. I'd be happy if morrita@ could take a look.

> Source/WebCore/ChangeLog:11
> +        Therfore duplicated implementation can be removed.

Typo: Therefore
Comment 3 Hajime Morrita 2012-11-19 18:49:16 PST 
Comment on attachment 174802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review

Looks good. Please fix some nit-picky bits on ChangeLog before landing.

> Source/WebCore/ChangeLog:8
> +        DeviceController need to be applied as parent class of DeviceMotionController

s/need/needs/
Comment 4 Kihong Kwon 2012-11-19 20:07:59 PST 
Created attachment 175125 [details]
Patch
Comment 5 Kihong Kwon 2012-11-20 03:06:26 PST 
Comment on attachment 175125 [details]
Patch

Thank you for your review, morrita. :)
Comment 6 WebKit Review Bot 2012-11-20 03:10:05 PST 
Comment on attachment 175125 [details]
Patch

Clearing flags on attachment: 175125

Committed r135268: <http://trac.webkit.org/changeset/135268>
Comment 7 WebKit Review Bot 2012-11-20 03:10:08 PST 
All reviewed patches have been landed.  Closing bug.