Bug 102578

Summary: Apply DeviceController as parent class of DeviceMotionController.
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebCore Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 96894    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kihong Kwon
Reported 2012-11-16 20:50:54 PST
DeviceOrientationController and DeviceMotionController have almost same structure. Therefore DeviceController which is extracted as parent class of them is added. In this patch, I apply DeviceController as parent class of DeviceMotionController.
Attachments
Patch (14.54 KB, patch)
2012-11-16 21:15 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (14.56 KB, patch)
2012-11-19 20:07 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-11-16 21:15:01 PST
Created attachment 174802 [details] Patch
Kentaro Hara
Comment 2 2012-11-19 03:25:33 PST
Comment on attachment 174802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review Looks reasonable to me but I'm not familiar with this area. I'd be happy if morrita@ could take a look. > Source/WebCore/ChangeLog:11 > + Therfore duplicated implementation can be removed. Typo: Therefore
Hajime Morrita
Comment 3 2012-11-19 18:49:16 PST
Comment on attachment 174802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review Looks good. Please fix some nit-picky bits on ChangeLog before landing. > Source/WebCore/ChangeLog:8 > + DeviceController need to be applied as parent class of DeviceMotionController s/need/needs/
Kihong Kwon
Comment 4 2012-11-19 20:07:59 PST
Created attachment 175125 [details] Patch
Kihong Kwon
Comment 5 2012-11-20 03:06:26 PST
Comment on attachment 175125 [details] Patch Thank you for your review, morrita. :)
WebKit Review Bot
Comment 6 2012-11-20 03:10:05 PST
Comment on attachment 175125 [details] Patch Clearing flags on attachment: 175125 Committed r135268: <http://trac.webkit.org/changeset/135268>
WebKit Review Bot
Comment 7 2012-11-20 03:10:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.