Bug 102567

Summary: Set task priority of WebKit2 processes to zero on Mac
Product: WebKit Reporter: Kiran Muppala <cmuppala>
Component: WebKit2Assignee: Kiran Muppala <cmuppala>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kiran Muppala
Reported 2012-11-16 16:00:08 PST
Set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS on Mac, to override automatic assignment by the kernel. This is a temporary fix until WebKit2 processes can better manage their own priority.
Attachments
Patch (4.05 KB, patch)
2012-11-16 16:05 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2012-11-16 16:34 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch (3.33 KB, patch)
2012-11-16 16:58 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kiran Muppala
Comment 1 2012-11-16 16:00:54 PST
<rdar://problem/12721417>
Kiran Muppala
Comment 2 2012-11-16 16:05:33 PST
Created attachment 174775 [details] Patch
Kiran Muppala
Comment 3 2012-11-16 16:34:13 PST
Created attachment 174780 [details] Patch
Mark Rowe (bdash)
Comment 4 2012-11-16 16:54:20 PST
Comment on attachment 174780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review > Source/WebKit2/ChangeLog:9 > + Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to > + override automatic priority determination by the system. This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0.
Kiran Muppala
Comment 5 2012-11-16 16:57:34 PST
(In reply to comment #4) > (From update of attachment 174780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review > > > Source/WebKit2/ChangeLog:9 > > + Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to > > + override automatic priority determination by the system. > > This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0. Yeah you are right. Fixing the bug title and change log.
Kiran Muppala
Comment 6 2012-11-16 16:58:52 PST
Created attachment 174784 [details] Patch
WebKit Review Bot
Comment 7 2012-11-16 17:34:55 PST
Comment on attachment 174784 [details] Patch Clearing flags on attachment: 174784 Committed r135020: <http://trac.webkit.org/changeset/135020>
WebKit Review Bot
Comment 8 2012-11-16 17:34:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.