Summary: | Set task priority of WebKit2 processes to zero on Mac | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran Muppala <cmuppala> | ||||||||
Component: | WebKit2 | Assignee: | Kiran Muppala <cmuppala> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kiran Muppala
2012-11-16 16:00:08 PST
Created attachment 174775 [details]
Patch
Created attachment 174780 [details]
Patch
Comment on attachment 174780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review > Source/WebKit2/ChangeLog:9 > + Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to > + override automatic priority determination by the system. This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0. (In reply to comment #4) > (From update of attachment 174780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review > > > Source/WebKit2/ChangeLog:9 > > + Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to > > + override automatic priority determination by the system. > > This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0. Yeah you are right. Fixing the bug title and change log. Created attachment 174784 [details]
Patch
Comment on attachment 174784 [details] Patch Clearing flags on attachment: 174784 Committed r135020: <http://trac.webkit.org/changeset/135020> All reviewed patches have been landed. Closing bug. |