Bug 102551

Summary: [CMake] Add support for winflexbison distribution
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, laszlo.gombos, mxie, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97592    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2012-11-16 12:34:16 PST
[CMake] Add support for winflexbison distribution
Attachments
Patch (1.66 KB, patch)
2012-11-16 12:39 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-11-16 12:39:29 PST
Created attachment 174746 [details] Patch
Laszlo Gombos
Comment 2 2012-11-18 16:22:31 PST
Comment on attachment 174746 [details] Patch r=me. It looks to me that all cmake based ports can have this change. It would be great to get a confirmation from the Blackberry port before committing the patch.
Laszlo Gombos
Comment 3 2012-11-23 08:02:35 PST
Rob or any of the BB folks - is this change ok for the BlackBerry port ? I just want to check if this would cause any regression before landing it.
Ming Xie
Comment 4 2012-11-23 08:38:48 PST
Just ran a test build with your patch, and the BlackBerry port builds fine. Please go ahead and submit your patch :)
Laszlo Gombos
Comment 5 2012-11-23 08:49:36 PST
Comment on attachment 174746 [details] Patch Thanks Ming.
WebKit Review Bot
Comment 6 2012-11-23 08:55:18 PST
Comment on attachment 174746 [details] Patch Clearing flags on attachment: 174746 Committed r135621: <http://trac.webkit.org/changeset/135621>
WebKit Review Bot
Comment 7 2012-11-23 08:55:23 PST
All reviewed patches have been landed. Closing bug.
Laszlo Gombos
Comment 8 2012-11-23 18:05:24 PST
Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks !
Patrick R. Gansterer
Comment 9 2012-11-26 11:13:59 PST
(In reply to comment #8) > Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks ! I already updated the binaries, but found an additional problem now. CMake does not recognice the version of win_flex, since it has a different output style. I'm already in contact with the win_flex developer and working on a CMake patch. If the patch is so importet for you I can make some changes in the installed CMake version to work around this problem for now. :-/
Note You need to log in before you can comment on or make changes to this bug.