Bug 102531

Summary: [EFL][WK2] Web Inspector crashes if evas_gl is not available
Product: WebKit Reporter: Yael <yael>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kenneth: review+
Patch
yael: commit-queue+
Patch none

Yael
Reported 2012-11-16 09:56:43 PST
We need to teach Web Inspector to fallback gracefully to the software path when evas_gl engine is not available. A patch is coming.
Attachments
Patch (1.57 KB, patch)
2012-11-16 10:00 PST, Yael 		kenneth: review+
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2012-11-19 13:11 PST, Yael 		yael: commit-queue+
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-11-19 13:16 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2012-11-16 10:00:14 PST
Created attachment 174713 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-11-19 12:38:42 PST
Comment on attachment 174713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93 > + if (!m_inspectorWindow) I would add comment here // Gracefully fall back to software if evas_gl engine is not available.
Yael
Comment 3 2012-11-19 13:11:49 PST
Created attachment 175032 [details] Patch (In reply to comment #2) > (From update of attachment 174713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review > > > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93 > > + if (!m_inspectorWindow) > > I would add comment here // Gracefully fall back to software if evas_gl engine is not available. Thank you for the review, I added the comment. I am not adding a warning as was done for the view, since Evas already gives a warning.
Yael
Comment 4 2012-11-19 13:16:34 PST
Created attachment 175033 [details] Patch Forgot to update the reviewer name.
WebKit Review Bot
Comment 5 2012-11-19 13:48:21 PST
Comment on attachment 175033 [details] Patch Clearing flags on attachment: 175033 Committed r135194: <http://trac.webkit.org/changeset/135194>
WebKit Review Bot
Comment 6 2012-11-19 13:48:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.