Bug 102516

Summary:

[BlackBerry] Enable Touch Sliders

Product:

WebKit

Reporter:

gmak

Component:

WebKit BlackBerry

Assignee:

Rob Buis <rwlbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, gyuyoung.kim, rakuco, rwlbuis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch with changelog	rwlbuis: review+, webkit.review.bot: commit-queue-
Patch - WebKit	none
Patch	none

gmak

Reported 2012-11-16 08:05:14 PST

Does as it says on the tin.

Attachments
Patch with changelog (5.09 KB, patch) 2012-11-16 08:08 PST, gmak	rwlbuis: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch - WebKit (5.32 KB, patch) 2012-11-16 08:50 PST, gmak	no flags	Details Formatted Diff Diff
Patch (4.49 KB, patch) 2012-11-18 16:00 PST, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

gmak

Comment 1 2012-11-16 08:08:31 PST

Created attachment 174687 [details] Patch with changelog

Rob Buis

Comment 2 2012-11-16 08:12:20 PST

Comment on attachment 174687 [details] Patch with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=174687&action=review Ok. > ChangeLog:3 > + Enable Touch Sliders Next time please match the real bug title. > Tools/ChangeLog:3 > + Enable Touch Sliders Ditto.

Antonio Gomes

Comment 3 2012-11-16 08:17:58 PST

Comment on attachment 174687 [details] Patch with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=174687&action=review Does not it allow you to remove code in TouchEventHandler class? > Tools/ChangeLog:8 > + PR # 242781 I thought https://bugzilla.qnx.com/bugzilla/show_bug.cgi?id=176014 :)

gmak

Comment 4 2012-11-16 08:20:21 PST

Antonio - Yeah I sort of duped it internally. Other code changes coming up separately.

WebKit Review Bot

Comment 5 2012-11-16 08:21:45 PST

Comment on attachment 174687 [details] Patch with changelog Rejecting attachment 174687 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14845929

gmak

Comment 6 2012-11-16 08:50:42 PST

Created attachment 174700 [details] Patch - WebKit

Rob Buis

Comment 7 2012-11-16 08:52:08 PST

Comment on attachment 174700 [details] Patch - WebKit LGTM.

WebKit Review Bot

Comment 8 2012-11-16 10:43:55 PST

Comment on attachment 174700 [details] Patch - WebKit Rejecting attachment 174700 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14861274

Rob Buis

Comment 9 2012-11-18 16:00:15 PST

Created attachment 174859 [details] Patch

Rob Buis

Comment 10 2012-11-18 16:00:56 PST

Comment on attachment 174859 [details] Patch Retrying

WebKit Review Bot

Comment 11 2012-11-18 16:41:41 PST

Comment on attachment 174859 [details] Patch Clearing flags on attachment: 174859 Committed r135088: <http://trac.webkit.org/changeset/135088>

WebKit Review Bot

Comment 12 2012-11-18 16:41:46 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.