[V8] Rename $className to $v8InterfaceName

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

In CodeGeneratorV8.pm, $className is always "V8$interfaceName". We should rename $className to $v8InterfaceName. Also we can remove GetCallbackClassName().

[Kentaro Hara]

Created attachment 174656 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174656 [details]
Patch

Rejecting attachment 174656 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
#29 succeeded at 3378 (offset -19 lines).
Hunk #30 succeeded at 3461 (offset -19 lines).
Hunk #31 succeeded at 3475 (offset -19 lines).
Hunk #32 succeeded at 4214 (offset -19 lines).
Hunk #33 succeeded at 4261 (offset -19 lines).
1 out of 33 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorV8.pm.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14868954

[Kentaro Hara]

Created attachment 174862 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 174862 [details]
patch for landing

Clearing flags on attachment: 174862

Committed r135092: <http://trac.webkit.org/changeset/135092>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.