Bug 102460

Summary: [EFL] Gardening, unskip passed tests
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: WebKit EFLAssignee: KwangYong Choi <ky0.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102650    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
webkit.review.bot: commit-queue-
Patch none

KwangYong Choi
Reported 2012-11-15 20:27:52 PST
-#Crash after r132386 -webkit.org/b/100342 fast/dom/nested-script-exceptions.html [ Crash ] -webkit.org/b/100342 networkinformation/multiple-frames.html [ Crash ] -webkit.org/b/100342 networkinformation/basic-all-types-of-events.html [ Crash ] -webkit.org/b/100342 networkinformation/updates.html [ Crash ] -webkit.org/b/100342 networkinformation/add-listener-from-callback.html [ Crash ] -webkit.org/b/100342 networkinformation/basic-operation.html [ Crash ]
Attachments
Patch (1.96 KB, patch)
2012-11-15 20:30 PST, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.96 KB, patch)
2012-11-15 20:33 PST, KwangYong Choi 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2012-11-18 17:21 PST, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-11-15 20:30:51 PST
Created attachment 174601 [details] Patch
KwangYong Choi
Comment 2 2012-11-15 20:33:48 PST
Created attachment 174602 [details] Patch
WebKit Review Bot
Comment 3 2012-11-18 12:53:21 PST
Comment on attachment 174602 [details] Patch Rejecting attachment 174602 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ipts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl-wk2/TestExpectations Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl-wk2/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14872886
KwangYong Choi
Comment 4 2012-11-18 17:21:56 PST
Created attachment 174864 [details] Patch Rebased.
WebKit Review Bot
Comment 5 2012-11-18 18:18:37 PST
Comment on attachment 174864 [details] Patch Clearing flags on attachment: 174864 Committed r135096: <http://trac.webkit.org/changeset/135096>
WebKit Review Bot
Comment 6 2012-11-18 18:18:41 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2012-11-18 23:19:13 PST
Those tests should NOT have been unskipped. They are crashing on the debug bots. If you want to unskip them for release, then just mark them as expected to crash for Debug only.
Note You need to log in before you can comment on or make changes to this bug.