Bug 102444

Summary: [Chromium-Android] Stack overflow in MediaControlsChromiumAndroid.cpp
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: DOMAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dino, eric.carlson, feature-media-reviews, qinmin, silviapf, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xianzhu Wang
Reported 2012-11-15 16:23:39 PST
PassRefPtr<MediaControls> MediaControls::create(Document* document) { return MediaControlsChromiumAndroid::create(document); } MediaControls::create calls itself. The 'create' should be 'createControls'.
Attachments
Patch (1.59 KB, patch)
2012-11-15 16:31 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-11-15 16:31:26 PST
Created attachment 174553 [details] Patch
Min Qin
Comment 2 2012-11-15 16:33:23 PST
lgtm
Silvia Pfeiffer
Comment 3 2012-11-15 16:33:51 PST
Thanks, lgtm
Xianzhu Wang
Comment 4 2012-11-16 09:13:32 PST
@dino and @eric.calson, can you r+?
WebKit Review Bot
Comment 5 2012-11-16 10:13:35 PST
Comment on attachment 174553 [details] Patch Clearing flags on attachment: 174553 Committed r134963: <http://trac.webkit.org/changeset/134963>
WebKit Review Bot
Comment 6 2012-11-16 10:13:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.