Bug 102444 - [Chromium-Android] Stack overflow in MediaControlsChromiumAndroid.cpp
Summary: [Chromium-Android] Stack overflow in MediaControlsChromiumAndroid.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-15 16:23 PST by Xianzhu Wang
Modified: 2012-11-16 10:13 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2012-11-15 16:31 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-11-15 16:23:39 PST 
PassRefPtr<MediaControls> MediaControls::create(Document* document)
{
    return MediaControlsChromiumAndroid::create(document);
}

MediaControls::create calls itself. The 'create' should be 'createControls'.
Comment 1 Xianzhu Wang 2012-11-15 16:31:26 PST 
Created attachment 174553 [details]
Patch
Comment 2 Min Qin 2012-11-15 16:33:23 PST 
lgtm
Comment 3 Silvia Pfeiffer 2012-11-15 16:33:51 PST 
Thanks, lgtm
Comment 4 Xianzhu Wang 2012-11-16 09:13:32 PST 
@dino and @eric.calson, can you r+?
Comment 5 WebKit Review Bot 2012-11-16 10:13:35 PST 
Comment on attachment 174553 [details]
Patch

Clearing flags on attachment: 174553

Committed r134963: <http://trac.webkit.org/changeset/134963>
Comment 6 WebKit Review Bot 2012-11-16 10:13:38 PST 
All reviewed patches have been landed.  Closing bug.