Summary: | Ignore autocomplete=off for chrome generated passwords. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yue Zhang <zysxqn> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yue Zhang
2012-11-15 13:54:51 PST
Created attachment 174510 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 174510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174510&action=review > Source/WebKit/chromium/public/WebPasswordFormData.h:101 > + // Value of shouldAutocomplete for the password element. > + bool passwordShouldAutocomplete; Can you add an inline constructor that initializes this value to something? Created attachment 174518 [details]
Patch
Comment on attachment 174518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174518&action=review > Source/WebKit/chromium/public/WebPasswordFormData.h:110 > + WebPasswordFormData(): passwordShouldAutocomplete(false) { } This isn't in quite the right style. The appropriate style is as follows: WebPasswordFormData() : passwordShouldAutocomplete(false) { } Created attachment 174521 [details]
Patch
Attachment 174521 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/public/WebPasswordFormData.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 174521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174521&action=review >> Source/WebKit/chromium/public/WebPasswordFormData.h:111 >> + : passwordShouldAutocomplete(false) > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Yeah, you need two more spaces. Created attachment 174522 [details]
Patch
Comment on attachment 174522 [details]
Patch
Yay! Thanks! :)
Comment on attachment 174522 [details] Patch Clearing flags on attachment: 174522 Committed r134852: <http://trac.webkit.org/changeset/134852> All reviewed patches have been landed. Closing bug. |