Bug 102422 – Add setChecked API in WebInputElement

• Component: Forms
• Status: RESOLVED FIXED

[Raman Kumar]

WebInputElement doesn't expose the underlying HTMLInputElement's setCheckout API. This is required to enable chromium to check a checkbox element.

[Raman Kumar]

Created attachment 174742 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 174742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please fill out this part of the ChangeLog.

> Source/WebKit/chromium/public/WebInputElement.h:77
> +        WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);

Can we use an enum for the second parameter rather than a raw boolean?  It looks like HTMLInputElement already uses an enum.

[Raman Kumar]

Created attachment 174761 [details]
Patch

[Raman Kumar]

Comment on attachment 174742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review

>> Source/WebKit/chromium/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Please fill out this part of the ChangeLog.

Done. Sorry for that, this is my first CL in webkit, still figuring out the process.

>> Source/WebKit/chromium/public/WebInputElement.h:77
>> +        WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);
> 
> Can we use an enum for the second parameter rather than a raw boolean?  It looks like HTMLInputElement already uses an enum.

This change is consistent with setValue(), HTMLInputElement's setValue also uses same enum. I don't exactly understand why bool was preferred here earlier, assuming there is a reason, I am trying to be consistent.

[Adam Barth]

Comment on attachment 174761 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 174761 [details]
Patch

Clearing flags on attachment: 174761

Committed r135016: <http://trac.webkit.org/changeset/135016>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.