Bug 102409

Summary: Text Autosizing: Improve handling of nested comments on reddit.com
Product: WebKit Reporter: John Mellor <johnme>
Component: Layout and RenderingAssignee: John Mellor <johnme>
Status: RESOLVED FIXED    
Severity: Normal CC: aadilkhan9409, ap, avayvod, eric, jchaffraix, kenneth, ojan, scdownloader.io, timvolodine, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.reddit.com/r/AskReddit/comments/138e4p/when_i_was_a_kid_my_parents_told_me_my_dog_was/
Bug Depends on: 105188    
Bug Blocks: 84186, 102408    
Attachments:
Description Flags
Screenshot of reddit.com comments
none
Patch
none
Screenshot of reddit.com comments with patch applied none

John Mellor
Reported 2012-11-15 10:08:04 PST
Created attachment 174475 [details] Screenshot of reddit.com comments Text Autosizing poorly handles the nested comment threads on reddit.com. See attached screenshot - ideally the comments would all share the same font size. This is similar to bug 102408, but on reddit.com the comments are forming clusters (see bug 97025) due to overflow:hidden and overflow:auto styles, rather than because they're wrapped in table cells.
Attachments
Screenshot of reddit.com comments (176.68 KB, image/png)
2012-11-15 10:08 PST, John Mellor 		no flags
Details
Patch (6.34 KB, patch)
2012-11-22 07:48 PST, John Mellor 		no flags
DetailsFormatted DiffDiff
Screenshot of reddit.com comments with patch applied (229.93 KB, image/png)
2012-11-22 07:51 PST, John Mellor 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
John Mellor
Comment 1 2012-11-22 07:48:33 PST
Created attachment 175673 [details] Patch
John Mellor
Comment 2 2012-11-22 07:51:42 PST
Created attachment 175675 [details] Screenshot of reddit.com comments with patch applied This is how reddit.com comments look with the new patch (i.e. their size is homogenous).
Kenneth Rohde Christiansen
Comment 3 2012-11-22 07:54:32 PST
Comment on attachment 175673 [details] Patch Nice, definitely looks better!
WebKit Review Bot
Comment 4 2012-11-22 18:54:53 PST
Comment on attachment 175673 [details] Patch Clearing flags on attachment: 175673 Committed r135553: <http://trac.webkit.org/changeset/135553>
WebKit Review Bot
Comment 5 2012-11-22 18:54:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.