Bug 102408

Summary: Text Autosizing: Improve handling of nested comments wrapped in tables
Product: WebKit Reporter: John Mellor <johnme>
Component: Layout and RenderingAssignee: John Mellor <johnme>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dbates, renpap40, timvolodine
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://news.ycombinator.com/item?id=4787965
Bug Depends on: 102409    
Bug Blocks: 84186    
Attachments:
Description Flags
Screenshot of news.ycombinator.com comments none

John Mellor
Reported 2012-11-15 10:00:00 PST
Created attachment 174474 [details] Screenshot of news.ycombinator.com comments Text Autosizing poorly handles nested comment lists on sites like news.ycombinator.com. See attached screenshot of news.ycombinator.com comments. Ideally, all the comments would end up with the same font size. But each comment is wrapped in a table cell (td), and the table cells each trigger a new cluster (see bug 97025). Clusters independently determine whether they contain enough text to bother autosizing at all (hence short comments don't get multiplied, but long comments do), and those clusters that do perform autosizing then independently determine their text autosizing multiplier based on their width, hence amongst the comments that get autosized the more deeply nested ones (which are narrower) get a smaller multiplier. Ultimately clustering needs to be smarter about tables.
Attachments
Screenshot of news.ycombinator.com comments (171.62 KB, image/png)
2012-11-15 10:00 PST, John Mellor 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-09-19 15:12:03 PDT
Marking this bug Resolved WontFix because the TEXT_AUTOSIZING feature was removed in <https://trac.webkit.org/changeset/206119> (bug #162167). See bug 84186, comment 32 for more details.
Note You need to log in before you can comment on or make changes to this bug.