Bug 102407

Summary: [V8] We shouldn't call deprecated V8 APIs
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, japhet, pfeldman, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2012-11-15 09:55:33 PST
[V8] We shouldn't call deprecated V8 APIs
Attachments
Patch (14.43 KB, patch)
2012-11-15 09:56 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (15.54 KB, patch)
2012-11-15 09:59 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-11-15 09:56:55 PST
Created attachment 174472 [details] Patch
Adam Barth
Comment 2 2012-11-15 09:59:03 PST
The ScriptProfiler code was added in http://trac.webkit.org/changeset/112861 by yurys and pfeldman.
Adam Barth
Comment 3 2012-11-15 09:59:24 PST
Created attachment 174473 [details] Patch
Eric Seidel (no email)
Comment 4 2012-11-15 10:25:12 PST
Comment on attachment 174473 [details] Patch rs=me.
Adam Barth
Comment 5 2012-11-15 11:30:13 PST
Comment on attachment 174473 [details] Patch The test added in http://trac.webkit.org/changeset/112861 seems to pass with this change. Given that the current code doesn't make much sense, I'm inclined to land this patch. Please let me know if we need to iterate on the ScriptProfiler.cpp part of the change.
WebKit Review Bot
Comment 6 2012-11-15 12:01:54 PST
Comment on attachment 174473 [details] Patch Clearing flags on attachment: 174473 Committed r134811: <http://trac.webkit.org/changeset/134811>
WebKit Review Bot
Comment 7 2012-11-15 12:01:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.