Bug 102395

Summary: Update DOMException name: NamespaceError
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101606    
Attachments:
Description Flags
Patch none

Description Erik Arvidsson 2012-11-15 08:47:15 PST
Update DOMException name: NamespaceError
Comment 1 Erik Arvidsson 2012-11-15 08:48:04 PST
Created attachment 174457 [details]
Patch
Comment 2 Kentaro Hara 2012-11-15 16:17:36 PST
Comment on attachment 174457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174457&action=review

ok

> LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt:10
> -PASS entityReference.prefix = 'foo' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
> +PASS entityReference.prefix = 'foo' threw exception Error: NamespaceError: DOM Exception 14.

Who is throwing this exception? I wonder why you need to update a test result even though you don't update any WebCore source code.
Comment 3 Erik Arvidsson 2012-11-15 19:17:37 PST
(In reply to comment #2)
> (From update of attachment 174457 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174457&action=review
> 
> ok
> 
> > LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt:10
> > -PASS entityReference.prefix = 'foo' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
> > +PASS entityReference.prefix = 'foo' threw exception Error: NamespaceError: DOM Exception 14.
> 
> Who is throwing this exception? I wonder why you need to update a test result even though you don't update any WebCore source code.

I updated the name property which is currently used in toString.
Comment 4 WebKit Review Bot 2012-11-15 19:29:44 PST
Comment on attachment 174457 [details]
Patch

Clearing flags on attachment: 174457

Committed r134879: <http://trac.webkit.org/changeset/134879>
Comment 5 WebKit Review Bot 2012-11-15 19:29:48 PST
All reviewed patches have been landed.  Closing bug.