Bug 102382

Summary: MediaStream API: Update RTCPeerConnection states to match the latest editors draft
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, ojan, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 102417    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tommy Widenflycht 2012-11-15 06:48:45 PST
MediaStream API: Update RTCPeerConnection states to match the latest editors draft
Comment 1 Tommy Widenflycht 2012-11-15 06:58:56 PST
Created attachment 174427 [details]
Patch
Comment 2 Tommy Widenflycht 2012-11-15 07:00:20 PST
http://dev.w3.org/2011/webrtc/editor/webrtc.html
Comment 3 WebKit Review Bot 2012-11-15 07:02:03 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Tommy Widenflycht 2012-11-15 07:03:48 PST
Created attachment 174429 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-15 11:02:15 PST
Comment on attachment 174429 [details]
Patch

Clearing flags on attachment: 174429

Committed r134800: <http://trac.webkit.org/changeset/134800>
Comment 6 WebKit Review Bot 2012-11-15 11:02:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-11-15 11:47:33 PST
Re-opened since this is blocked by bug 102417
Comment 8 Tommy Widenflycht 2012-11-16 01:31:49 PST
Created attachment 174631 [details]
Patch
Comment 9 Tommy Widenflycht 2012-11-16 01:34:20 PST
This patch just differs from the previous one in that the new method in WebRTCPeerConnectionHandlerClient now has an default implementation instead of being pure virtual.
Comment 10 Adam Barth 2012-11-16 09:21:50 PST
Comment on attachment 174631 [details]
Patch

ok
Comment 11 WebKit Review Bot 2012-11-16 10:18:59 PST
Comment on attachment 174631 [details]
Patch

Rejecting attachment 174631 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/14846905
Comment 12 WebKit Review Bot 2012-11-16 11:37:03 PST
Comment on attachment 174631 [details]
Patch

Clearing flags on attachment: 174631

Committed r134976: <http://trac.webkit.org/changeset/134976>
Comment 13 WebKit Review Bot 2012-11-16 11:37:08 PST
All reviewed patches have been landed.  Closing bug.