Summary: | MediaStream API: Update RTCPeerConnection states to match the latest editors draft | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tommy Widenflycht <tommyw> | ||||||||
Component: | WebCore Misc. | Assignee: | Tommy Widenflycht <tommyw> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, ojan, tkent+wkapi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 102417 | ||||||||||
Bug Blocks: | 56459 | ||||||||||
Attachments: |
|
Description
Tommy Widenflycht
2012-11-15 06:48:45 PST
Created attachment 174427 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 174429 [details]
Patch
Comment on attachment 174429 [details] Patch Clearing flags on attachment: 174429 Committed r134800: <http://trac.webkit.org/changeset/134800> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 102417 Created attachment 174631 [details]
Patch
This patch just differs from the previous one in that the new method in WebRTCPeerConnectionHandlerClient now has an default implementation instead of being pure virtual. Comment on attachment 174631 [details]
Patch
ok
Comment on attachment 174631 [details] Patch Rejecting attachment 174631 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/14846905 Comment on attachment 174631 [details] Patch Clearing flags on attachment: 174631 Committed r134976: <http://trac.webkit.org/changeset/134976> All reviewed patches have been landed. Closing bug. |