Bug 102343

Summary: Remove coneGain and distanceGain attributes from PannerNode.idl
Product: WebKit Reporter: Li Yin <li.yin>
Component: Web AudioAssignee: Li Yin <li.yin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Li Yin
Reported 2012-11-14 23:42:44 PST
Removing .coneGain and .distanceGain as publicly accessible values, since normally they only need to be calculated internally.
Attachments
Patch (1.44 KB, patch)
2012-11-14 23:47 PST, Li Yin 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-11-16 22:20 PST, Li Yin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Li Yin
Comment 1 2012-11-14 23:47:41 PST
Created attachment 174362 [details] Patch
Chris Rogers
Comment 2 2012-11-16 10:30:15 PST
Comment on attachment 174362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review Li, thanks this looks good with minor nit. > Source/WebCore/ChangeLog:11 > + No new tests. No change in functionality. This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed."
Li Yin
Comment 3 2012-11-16 22:20:00 PST
Created attachment 174807 [details] Patch
Li Yin
Comment 4 2012-11-16 22:20:58 PST
(In reply to comment #2) > (From update of attachment 174362 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review > > Li, thanks this looks good with minor nit. > > > Source/WebCore/ChangeLog:11 > > + No new tests. No change in functionality. > > This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed." Done. Thanks for your comments.
Chris Rogers
Comment 5 2012-11-17 11:46:37 PST
Comment on attachment 174807 [details] Patch thanks
WebKit Review Bot
Comment 6 2012-11-17 12:06:52 PST
Comment on attachment 174807 [details] Patch Clearing flags on attachment: 174807 Committed r135050: <http://trac.webkit.org/changeset/135050>
WebKit Review Bot
Comment 7 2012-11-17 12:06:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.