Bug 102338

Summary: Remove CodeGenerator::StripModule
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, tasak, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-11-14 22:49:26 PST
Now WebKit IDL files have no modules. (The Web IDL spec has no modules.) We can remove CodeGenerator::StripModule. This might break some internal builds if the internal builds are still using modules. So I'll land it when I can stay on IRC.
Attachments
Patch (21.70 KB, patch)
2012-11-14 22:51 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (21.68 KB, patch)
2012-11-14 23:02 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-14 22:51:21 PST
Created attachment 174354 [details] Patch
Early Warning System Bot
Comment 2 2012-11-14 22:57:50 PST
Comment on attachment 174354 [details] Patch Attachment 174354 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14843452
EFL EWS Bot
Comment 3 2012-11-14 22:59:11 PST
Comment on attachment 174354 [details] Patch Attachment 174354 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14846275
Early Warning System Bot
Comment 4 2012-11-14 23:00:44 PST
Comment on attachment 174354 [details] Patch Attachment 174354 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14844374
Kentaro Hara
Comment 5 2012-11-14 23:02:15 PST
Created attachment 174356 [details] Patch
WebKit Review Bot
Comment 6 2012-11-15 16:17:11 PST
Comment on attachment 174356 [details] Patch Clearing flags on attachment: 174356 Committed r134849: <http://trac.webkit.org/changeset/134849>
WebKit Review Bot
Comment 7 2012-11-15 16:17:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.