Bug 102322

Summary: IndexedDB: remove setVersion from intversion-long-queue
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Grogan
Reported 2012-11-14 19:51:42 PST
IndexedDB: remove setVersion from intversion-long-queue
Attachments
Patch (13.65 KB, patch)
2012-11-14 19:54 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (13.57 KB, patch)
2012-11-15 14:16 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-11-14 19:54:53 PST
Created attachment 174326 [details] Patch
David Grogan
Comment 2 2012-11-14 19:55:21 PST
Josh, could you take a look at this one also?
Joshua Bell
Comment 3 2012-11-15 13:40:18 PST
Comment on attachment 174326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174326&action=review lgtm with nits > LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:66 > + shouldBeNonNull("event.oldVersion"); Can you make this expect a specific version? > LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:99 > + debug("FIXME: Fire a versionchange event that has oldVersion and newVersion"); Isn't this already correct? If not, I'd expect a FAIL here (e.g. on the event type?)
David Grogan
Comment 4 2012-11-15 14:05:39 PST
Comment on attachment 174326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174326&action=review >> LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:66 >> + shouldBeNonNull("event.oldVersion"); > > Can you make this expect a specific version? Done >> LayoutTests/storage/indexeddb/resources/intversion-long-queue.js:99 >> + debug("FIXME: Fire a versionchange event that has oldVersion and newVersion"); > > Isn't this already correct? If not, I'd expect a FAIL here (e.g. on the event type?) Oops, removed.
David Grogan
Comment 5 2012-11-15 14:16:43 PST
Created attachment 174515 [details] Patch
David Grogan
Comment 6 2012-11-15 14:20:11 PST
Tony, could you review this?
WebKit Review Bot
Comment 7 2012-11-15 16:10:55 PST
Comment on attachment 174515 [details] Patch Clearing flags on attachment: 174515 Committed r134844: <http://trac.webkit.org/changeset/134844>
WebKit Review Bot
Comment 8 2012-11-15 16:10:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.