Bug 102319

Summary: [chromium] Move allowWebGL query to WebFrameClient
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bajones, dglazkov, fishd, gman, jamesr, tkent+wkapi, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 101826    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2012-11-14 19:30:57 PST
After offline discussion, the allowWebGL query added in https://bugs.webkit.org/show_bug.cgi?id=101826 needs to be moved from WebPermissionClient to WebFrameClient in order to keep its implementation in the content/ module and avoid polluting the content/ API.
Attachments
Patch (3.55 KB, patch)
2012-11-14 19:39 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2012-11-14 19:39:53 PST
Created attachment 174323 [details] Patch
WebKit Review Bot
Comment 2 2012-11-14 19:42:23 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-11-15 10:02:35 PST
Comment on attachment 174323 [details] Patch I'm slightly hesitant to design the WebKit API around the higher-level abstractions in Chromium, but this change seems ok.
WebKit Review Bot
Comment 4 2012-11-15 10:34:05 PST
Comment on attachment 174323 [details] Patch Clearing flags on attachment: 174323 Committed r134794: <http://trac.webkit.org/changeset/134794>
WebKit Review Bot
Comment 5 2012-11-15 10:34:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.