Bug 102300 – Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.

[Jer Noble]

Created attachment 174292 [details]
Patch

[Sam Weinig]

Comment on attachment 174292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174292&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:84
> +    [_exitWarning.get() setHidden:!visible];
> +    if (visible) {
> +        CIFilter* filter = [CIFilter filterWithName:@"CIFalseColor" keysAndValues:
> +                            @"inputColor0", [CIColor colorWithRed:0 green:0 blue:0],
> +                            @"inputColor1", [CIColor colorWithRed:.9 green:.9 blue:.9],
> +                            nil];
> +        [[self layer] setCompositingFilter:filter];
> +    } else
> +        [[self layer] setCompositingFilter:nil];

We should try to do this without using CoreImage.  CoreImage doesn't play nice with our layer hosting strategy.

[Jer Noble]

Created attachment 176098 [details]
Patch

Removed the CIFilter, replacing it with a simple greyscale overlay layer.

[Jer Noble]

Created attachment 176340 [details]
Patch

[Anders Carlsson]

Comment on attachment 176340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176340&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:55
> +    warningFrame.origin = NSMakePoint(
> +                                      (frameRect.size.width - warningFrame.size.width) / 2,
> +                                      (frameRect.size.height - warningFrame.size.height) / 2);

Remove the newlines here.

[Jer Noble]

Committed r135941: <http://trac.webkit.org/changeset/135941>