Bug 102299 – Add a new shared class WebCoreFullScreenWarningView which presents a styled warning message.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Add a new shared class WebCoreFullScreenWarningView which presents a styled warning message.

[Jer Noble]

Created attachment 174290 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 174290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174290&action=review

I don't know why anyone in the world would do layout with anything other than HTML :-p

r=style bot

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:28
> +#include "WebCoreFullScreenWarningView.h"
> +#include "LocalizedStrings.h"

There should be a blank line between these.

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:45
> +static const NSTimeInterval WarningViewHideDelay = 3.0;

You got all of them right, except for this one, should be just "3".

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:66
> +    RetainPtr<NSFont> textFont = [NSFont boldSystemFontOfSize:WarningViewTextSize];

No good in retaining it, just refcount churn.

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:67
> +    RetainPtr<NSColor> textColor = [NSColor colorWithCalibratedWhite:WarningViewTextWhite alpha:WarningViewTextAlpha];

No good in retaining it, just refcount churn.

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:91
> +    RetainPtr<NSColor> backgroundColor = [NSColor colorWithCalibratedWhite:WarningViewBackgroundWhite alpha:WarningViewBackgroundAlpha];

No good in retaining it, just refcount churn.

> Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:99
> +    RetainPtr<NSColor> shadowColor = [NSColor colorWithCalibratedWhite:WarningViewShadowWhite alpha:WarningViewShadowAlpha];

No good in retaining it, just refcount churn.

[Jer Noble]

Committed r135937: <http://trac.webkit.org/changeset/135937>