Bug 102290
| Summary: | IndexedDB: Ensure structured clone test exercises serialization/deserialization | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joshua Bell <jsbell> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | alecflett, dgrogan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Joshua Bell
LayoutTests/storage/indexeddb/structured-clone.html has:
evalAndLog("store = db.createObjectStore('storeName')");
debug("This index is not used, but evaluating key path on each put() call will exercise (de)serialization:");
evalAndLog("store.createIndex('indexName', 'dummyKeyPath')");
... but now that we compute index keys in the front end using ScriptValue we do not necessarily serialize/deserialize.
We should update the test to ensure values can be stored and fetched back out again.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alec Flett
I feel like all of our existing tests cover whatever we'd want to cover here?
Joshua Bell
Actually, in reviewing the structured-clone.html test, we do store/retrieve the values, so it's good enough IMHO.
Joshua Bell
(In reply to comment #1)
> I feel like all of our existing tests cover whatever we'd want to cover here?
I'd thought we only e.g, stored them to make sure they didn't crash, and relied on index computation to deserialize/re-serialize. My bad.