Bug 102289

Summary:

Cleanup BasicShape blending check

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

CSS

Assignee:

Dirk Schulze <krit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

95389

Attachments:

Description	Flags
Patch	dbates: review+

Description Dirk Schulze 2012-11-14 14:56:56 PST

We have the same checks if two BasicShape objects can be blended twice. Refactor the code and add a canBlend method in BasicShape that combined the check.

Comment 1 Dirk Schulze 2012-11-14 15:18:27 PST

Created attachment 174268 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-11-14 15:25:13 PST

Comment on attachment 174268 [details]
Patch

The double-negatives are a bit confusing.  But this looks right.

Comment 3 Dirk Schulze 2012-11-14 15:27:53 PST

Committed r134679: <http://trac.webkit.org/changeset/134679>